BBS:      TELESC.NET.BR
Assunto:  src/syncterm/ssh.c
De:       Deuc¨
Data:     Sun, 15 Mar 2026 01:06:05 -0700
-----------------------------------------------------------
https://gitlab.synchro.net/main/sbbs/-/commit/a45466867429f3ad7043fb5e
Modified Files:
	src/syncterm/ssh.c
Log Message:
Add missing NULL checks on malloc() in ssh_connect()

conn_api.rd_buf and conn_api.wr_buf were allocated with malloc() but
never checked for failure.  The I/O threads started immediately after
would dereference the NULL pointers and crash.  Other connection types
(conn_pty.c, conn_conpty.c, modem.c, rlogin.c) already had these
checks; ssh.c was an oversight.

The error paths also free(pubkey), which is either a valid allocation
from get_public_key() or the initial NULL  both safe for free().

Co-Authored-By: Claude Opus 4.6 
n
---
  mSynchronetn  hgVertrauen n hHome of Synchronet n gh[vert/cvs/bbs].synchro.net

-----------------------------------------------------------
[Voltar]